This revision was automatically updated to reflect the committed changes.
Closed by commit rL284830: Add data formatter for libstdc++ unique_ptr
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D25734?vs=75425=75432#toc
Repository:
rL LLVM
Eugene.Zelenko added a comment.
Headers orders is still not correct.
https://reviews.llvm.org/D25734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added inline comments.
Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:110
+ if (name == ConstString("ptr") || name == ConstString("pointer")) return 2;
+ return UINT32_MAX;
+}
labath wrote:
> ~0 ?
The user compares the
tberghammer updated this revision to Diff 75425.
tberghammer marked 2 inline comments as done.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D25734
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile
On 19 October 2016 at 18:39, Jim Ingham wrote:
>
>> On Oct 19, 2016, at 10:38 AM, Jim Ingham via lldb-commits
>> wrote:
>>
>>
>>> On Oct 19, 2016, at 6:35 AM, Pavel Labath via lldb-commits
>>> wrote:
>>>
>>>
>>>
granata.enrico added a comment.
I see you already got a bunch of feedback on specific items. The overall idea
looks good to me. I'll try to delve a little deeper in the code ASAP (I was out
for a couple days and have some backlog...), but should be good to go assuming
you address the feedback
> On Oct 19, 2016, at 10:38 AM, Jim Ingham via lldb-commits
> wrote:
>
>
>> On Oct 19, 2016, at 6:35 AM, Pavel Labath via lldb-commits
>> wrote:
>>
>>
>>
>> Comment at:
labath added a comment.
Looks fine with the usual comments. :)
Comment at:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/unique_ptr/Makefile:5
+
+CXXFLAGS := -O0
+USE_LIBSTDCPP := 1
Same comments as the previous
Eugene.Zelenko added a comment.
There are same problems with formatting as in https://reviews.llvm.org/D25726.
Also test case main() has wrong indentation.
https://reviews.llvm.org/D25734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tberghammer created this revision.
tberghammer added reviewers: labath, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Add data formatter for libstdc++ unique_ptr
https://reviews.llvm.org/D25734
Files:
10 matches
Mail list logo