This revision was automatically updated to reflect the committed changes.
Closed by commit rL285838: Find clang resource directory via *nix-style lookup
(authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D26170?vs=76496&id=76735#toc
Repository:
rL LLVM
https://review
labath added a comment.
looks good in general, but please check whether this is correct with
LLVM_LIBDIR_SUFFIX=64.
Comment at: source/Host/posix/HostInfoPosix.cpp:176
+ file_spec,
+ llvm::Twine("/lib/clang/", llvm::StringRef(CLANG_VERSION_STRING)).str());
+}
---
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks reasonable.
Comment at: source/Host/macosx/HostInfoMacOSX.mm:235-239
size_t framework_pos = raw_path.find("LLDB.framework");
- if (framework_pos != std::string::npo
beanz created this revision.
beanz added reviewers: zturner, labath, spyffe, tfiala.
beanz added a subscriber: lldb-commits.
This patch allows the Darwin build to fall back to to Posix-style lookups for
the clang resource directory if the debugger library isn't inside a framework.
The patch also
