[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

2016-12-15 Thread Todd Fiala via Phabricator via lldb-commits
tfiala abandoned this revision. tfiala added a comment. This one needs more analysis. I'm bowing out of it. Greg, you might want to pick this one up? https://reviews.llvm.org/D26510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

2016-11-22 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We will need to take a look at the existing assert calls within LLDB and within LLVM to make sure we won't cause things to crash at a later time with no context as to what

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

2016-11-10 Thread Greg Clayton via lldb-commits
clayborg added a comment. If we do this the asserts we have will no longer fire. We tend not to use asserts too much, but it would be a good idea to take a look at any asserts in our code to make sure we won't die horribly in other ways that will cause us not to know what crashed us.