[Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

2016-11-17 Thread Jim Ingham via lldb-commits
jingham added a comment. Excellent, thanks for catching that. https://reviews.llvm.org/D26804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

2016-11-17 Thread Jim Ingham via lldb-commits
Ah, good catch. That is not right. If there’s inlined function information, you want to make sure you haven’t gone from one inlined function to another. But the symbol is always going to be the same in this case. Actually, the old code is a overly restrictive by comparing the blocks

[Lldb-commits] [PATCH] D26804: Fix step-over when SymbolContext.function is missing and symbol is present.

2016-11-17 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That way of doing it is fine too. https://reviews.llvm.org/D26804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org