This revision was automatically updated to reflect the committed changes.
Closed by commit rL289211: [LLDB][MIPS] Fix TestWatchpointIter failure
(authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D27124?vs=80414=80895#toc
Repository:
rL LLVM
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Great, thanks!
https://reviews.llvm.org/D27124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
nitesh.jain updated this revision to Diff 80414.
nitesh.jain added a comment.
Update diff as per suggestion
https://reviews.llvm.org/D27124
Files:
source/Target/StopInfo.cpp
Index: source/Target/StopInfo.cpp
===
---
jingham added a comment.
This looks fine. Can you add a comment explaining why this is necessary, it
isn't obvious right off the bat?
If this is fixing a test case, then just add a comment and this change is fine.
If the fix is test-suite neutral, then please add a test case.
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I let Jim OK this patch.
https://reviews.llvm.org/D27124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
nitesh.jain updated the summary for this revision.
nitesh.jain updated this revision to Diff 79864.
nitesh.jain added a comment.
Updated diff as per suggestion.
https://reviews.llvm.org/D27124
Files:
source/Target/StopInfo.cpp
Index: source/Target/StopInfo.cpp
