abidh accepted this revision.
abidh added a reviewer: abidh.
abidh marked an inline comment as done.
abidh added a comment.
This revision is now accepted and ready to land.
Accepted in email.
https://reviews.llvm.org/D27759
___
lldb-commits mailing
abidh updated this revision to Diff 81576.
abidh added a comment.
Replaced /D with -D as per comments.
https://reviews.llvm.org/D27759
Files:
cmake/LLDBDependencies.cmake
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBConfig.cmake
include/lldb/Host/windows/windows.h
Looks good
On Thu, Dec 15, 2016 at 2:16 AM Hafiz Abid Qadeer via Phabricator <
revi...@reviews.llvm.org> wrote:
> abidh added a comment.
>
> In https://reviews.llvm.org/D27759#622332, @labath wrote:
>
> > Yeah, I meant using it everywhere as a generic "am I on windows,
> regardless of the
abidh added a comment.
In https://reviews.llvm.org/D27759#622332, @labath wrote:
> Yeah, I meant using it everywhere as a generic "am I on windows, regardless
> of the compiler" check. (Assuming Zach is fine with that)
OK. If Zachary is fine with that then I can do that in a separate commit.
labath added a comment.
Yeah, I meant using it everywhere as a generic "am I on windows, regardless of
the compiler" check. (Assuming Zach is fine with that)
https://reviews.llvm.org/D27759
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
abidh added a comment.
> BTW, I am curious, are you planning on building python with mingw as well? If
> you are, I'd be interested in knowing how that works out.
I would like to do it but have not done it yet. I will keep you posted.
Comment at:
zturner added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:246
+if (MSVC)
+add_definitions( /D _UNICODE /D UNICODE )
+elseif (MINGW)
labath wrote:
> Could you check if it's enough to pass `-DFOO` regardless of the platform.
> This is the only
labath added a comment.
I'll leave Zachary to approve, but it seems reasonable.
BTW, I am curious, are you planning on building python with mingw as well? If
you are, I'd be interested in knowing how that works out.
Comment at: cmake/modules/LLDBConfig.cmake:246
+if (MSVC)
+
abidh created this revision.
abidh added reviewers: labath, zturner.
abidh added a subscriber: lldb-commits.
Herald added subscribers: mgorny, ki.stfu.
I was building lldb using cross mingw-w64 toolchain on Linux and observed some
issues. This is first patch in the series to fix that build. It
