This revision was automatically updated to reflect the committed changes.
Closed by commit rL291559: Improve Type::GetTypeScopeAndBasenameHelper and add
unit tests (authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D28466?vs=83669=83791#toc
Repository:
rL LLVM
tberghammer updated this revision to Diff 83669.
tberghammer marked 9 inline comments as done.
https://reviews.llvm.org/D28466
Files:
include/lldb/Symbol/Type.h
source/Core/Module.cpp
source/Symbol/Type.cpp
source/Symbol/TypeList.cpp
source/Symbol/TypeMap.cpp
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Switch over to using llvm::StringRef in the functions where mentioned.
Comment at: source/Symbol/Type.cpp:623
bool Type::GetTypeScopeAndBasename(const char
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added a subscriber: mgorny.
Improve Type::GetTypeScopeAndBasenameHelper and add unit tests
Previously it failed to handle nested types inside templated classes
