This revision was automatically updated to reflect the committed changes.
Closed by commit rL295822: Replace WINLOG_*** macros with LLDB_LOG (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D30172?vs=89130=89342#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30172
labath added a comment.
In https://reviews.llvm.org/D30172#682789, @amccarth wrote:
> Maybe we have too many categories.
Thanks. I was thinking about that as well. Currently there is about 110 log
statements in the windows log and 8 log categories. Things wouldn't get too
noisy even if we
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM.
Maybe we have too many categories.
Comment at: source/Plugins/Process/Windows/Common/DebuggerThread.cpp:207
if (m_active_exception.get()) {
-
labath created this revision.
The main difference here is that in the WINLOG macros you can specify
log categories per call, whereas here you have to go the usual lldb
route of getting a Log* variable first. While this means you have to
write at least two statements, it usually means that each
