This revision was automatically updated to reflect the committed changes.
Closed by commit rL295950: Reformat inferior's main.cpp in lldb-server test
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30234?vs=89404&id=89480#toc
Repository:
rL LLVM
https://reviews.llvm
labath accepted this revision.
labath added a comment.
In https://reviews.llvm.org/D30234#683880, @eugene wrote:
> I have added local .clang-format file. But it didn't change the way main.cpp
> was formated.
That's fine, I did not expect that to make a difference now. What it will do
though,
eugene updated this revision to Diff 89404.
eugene added a comment.
I have added local .clang-format file. But it didn't change the way main.cpp
was formated.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/.clang-format
packages/Python/lldbsuite/tes
labath added a comment.
clang-format did not pick up the correct formatting because we have a
`.clang-format` file in `packages/Python/lldbsuite`. This was necessary because
a lot of the tests would get broken, as the formatting would break our `//
place breakpoint here` annotations (also, step
krytarowski added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:74
+ printf("%" PRIx64, static_cast(syscall(__NR_gettid)));
#else
+ printf("{no-tid-support}");
Note to self -
```
#elif defined(__NetBSD__)
printf("%" PR
eugene marked an inline comment as done.
eugene added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:32-42
+static const char *const RETVAL_PREFIX = "retval:";
+static const char *const SLEEP_PREFIX = "sleep:";
+static const char *const STD
eugene added a comment.
In https://reviews.llvm.org/D30234#683018, @jingham wrote:
> Anyway, it might be better just to do that to this file using the top level
> .clang-format. Note that you are making several choices which were not the
> choices made by clang-format using the .clang-format f
eugene updated this revision to Diff 89312.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
===
--- packages/Python/
eugene updated this revision to Diff 89311.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
===
--- packages/Python/
jingham added a comment.
Actually, we didn't run the clang-format over the test case source files, since
we didn't want to have to deal with the possible failures resulting. So just
clang-formatting this file is probably the right way to go.
https://reviews.llvm.org/D30234
jingham added a comment.
It looks like clang-format wasn't run over this file as it was over all the
main lldb sources in the infamous universal code reformatting. That seems odd.
Anyway, it might be better just to do that to this file using the top level
.clang-format. Note that you are maki
eugene added a comment.
In https://reviews.llvm.org/D30234#682990, @jmajors wrote:
> Do we have any plans to put something like cpplint into effect?
First step would be to have warning free build.
Then we can turn "warnings as errors" on.
https://reviews.llvm.org/D30234
___
jmajors accepted this revision.
jmajors added a comment.
This revision is now accepted and ready to land.
Do we have any plans to put something like cpplint into effect?
https://reviews.llvm.org/D30234
___
lldb-commits mailing list
lldb-commits@list
eugene created this revision.
eugene added a project: LLDB.
main.cpp is complete mess of tabs and spaces. This change brings it to
compliance with LLVM coding style.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbs
14 matches
Mail list logo
