[Lldb-commits] [PATCH] D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64

2017-02-23 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski updated this revision to Diff 89589. krytarowski added a comment. - remove unused function `GetSharedRegisterInfoVector` - fix `DR_OFFSET` Repository: rL LLVM https://reviews.llvm.org/D30287 Files: source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp Index: source/P

[Lldb-commits] [PATCH] D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64

2017-02-23 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. That is fine, just wanted to check. Repository: rL LLVM https://reviews.llvm.org/D30287 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64

2017-02-23 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:51-56 + uint64_t dr[16]; /* debug registers */ + /* Index 0-3: debug address registers */ + /* Index 4-5: reserved */ +

[Lldb-commits] [PATCH] D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64

2017-02-23 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:51-56 + uint64_t dr[16]; /* debug registers */ + /* Index 0-3: debug address registers */ + /* Index 4-5: reserved */ +

[Lldb-commits] [PATCH] D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64

2017-02-23 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Good stuff, just remove the unused function. Comment at: source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp:87 + +static std::vector &GetSharedRegisterInfoVector