This revision was automatically updated to reflect the committed changes.
Closed by commit rL297685: [debugserver] This is a small cleanup patch to AVX
support detection (authored by cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D30918?vs=91644=91645#toc
Repository:
rL LLVM
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
looks good to me.
Comment at: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp:66
+ int error = ::sysctlbyname(feature, , _size, NULL, 0);
+ return
beanz updated this revision to Diff 91643.
beanz added a comment.
Updates based on feedback from Jason and Zachary.
https://reviews.llvm.org/D30918
Files:
tools/debugserver/debugserver.xcodeproj/project.pbxproj
tools/debugserver/source/MacOSX/CMakeLists.txt
zturner added inline comments.
Comment at: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp:66
+ int error = ::sysctlbyname(feature, , _size, NULL, 0);
+ return !error & answer;
+}
jasonmolenda wrote:
> I see what you're doing -- this can either
jasonmolenda added a comment.
Hah, I misread what the 'buffer[first_letter] & 0x40' line was doing still.
Maybe use isupper() here instead of the bitmask?
https://reviews.llvm.org/D30918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jasonmolenda requested changes to this revision.
jasonmolenda added a comment.
This revision now requires changes to proceed.
Looks good, a few small suggestions from reading the code afresh. I'm not sure
how many open source contributors we may have running macOS 10.6 or earlier (or
macOS
beanz updated this revision to Diff 91640.
beanz added a comment.
Removing some extra changes that accidentally came along for the ride in my
initial upload.
https://reviews.llvm.org/D30918
Files:
tools/debugserver/debugserver.xcodeproj/project.pbxproj
beanz created this revision.
Herald added a subscriber: mgorny.
The first Sandybridge iMacs with AVX support shipped in Spring 2011 with Snow
Leopard as their OS. Unfortunately due to a kernel bug debugging AVX code was
not really possible until 10.7.4.
The old code here checked the kernel
