labath added inline comments.
Comment at: source/CMakeLists.txt:25
+include_directories(
+ Plugins/Process/POSIX
+ )
krytarowski wrote:
> @labath are the includes for Plugins/Process/FreeBSD and
> Plugins/Process/FreeBSD necessary? I don't need to add Plugins/
krytarowski added a comment.
In https://reviews.llvm.org/D31131#710862, @kettenis wrote:
> Can somebody commit this diff for me?
Sure, I'm on it.
https://reviews.llvm.org/D31131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
kettenis added a comment.
Can somebody commit this diff for me?
https://reviews.llvm.org/D31131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextOpenBSD_i386.cpp:48
+ GPR gpr;
+ FPR_i386 i387;
+};
kettenis wrote:
> krytarowski wrote:
> > no DBG regs here?
> OpenBSD doesn't actually implement access to the debug
kettenis updated this revision to Diff 92938.
kettenis added a comment.
Updated diff to account for the FileSpec.h move.
https://reviews.llvm.org/D31131
Files:
include/lldb/Host/Config.h
include/lldb/Host/Editline.h
include/lldb/Host/Host.h
include/lldb/Host/HostInfo.h
include/lldb/Ho
kettenis added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextOpenBSD_i386.cpp:48
+ GPR gpr;
+ FPR_i386 i387;
+};
krytarowski wrote:
> no DBG regs here?
OpenBSD doesn't actually implement access to the debug registers.
https://revi
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
In general it looks good.
https://reviews.llvm.org/D31131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
krytarowski added inline comments.
Comment at: source/CMakeLists.txt:25
+include_directories(
+ Plugins/Process/POSIX
+ )
@labath are the includes for Plugins/Process/FreeBSD and
Plugins/Process/FreeBSD necessary? I don't need to add Plugins/Process/NetBSD
in
kettenis updated this revision to Diff 92861.
kettenis added a comment.
Apologies. Previous diff contained a bogus change to DYLDRendezvous.cpp and a
formatting botch. Please review this updated version instead,
https://reviews.llvm.org/D31131
Files:
include/lldb/Host/Config.h
include/ll
kettenis updated this revision to Diff 92857.
kettenis marked an inline comment as done.
kettenis edited the summary of this revision.
kettenis added a comment.
Herald added subscribers: srhines, rengolin, emaste, aemerson.
New diff. This one adds support for OpenBSD/amd64, OpenBSD/arm, OpenBSD/ar
krytarowski added inline comments.
Comment at: source/Host/openbsd/HostInfoOpenBSD.cpp:20
+
+uint32_t HostInfoOpenBSD::GetMaxThreadNameLength() { return 16; }
+
The need for this has been removed in trunk.
Repository:
rL LLVM
https://reviews.llvm.org/D31131
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:588
+ }
+} else if (strncmp(note.n_name.c_str(), "OpenBSD", 7) == 0) {
+ m_os = llvm::Triple::OpenBSD;
kettenis wrote:
> krytarowski wrote:
> > `note.n
krytarowski added inline comments.
Comment at: include/lldb/Host/HostInfo.h:55
+#elif defined(__OpenBSD__)
+#include "lldb/Host/openbsd/HostInfoOpenBSD.h"
+#define HOST_INFO_TYPE HostInfoOpenBSD
kettenis wrote:
> krytarowski wrote:
> > I would sort includes here.
kettenis marked 2 inline comments as done.
kettenis added a comment.
Will revise the diff based on your comments. Thanks!
Comment at: include/lldb/Host/Config.h:35
+
+#include "lldb/Host/openbsd/Config.h"
krytarowski wrote:
> krytarowski wrote:
> > Missing in
labath added a comment.
Looks like a great start. If you want to continue and get live process
debugging working as well, you should definitely sync up with kamil (i.e. don't
start from ProcessFreeBSD, his process plugin should be a much better starting
point).
In terms of this patch, I have a
krytarowski added inline comments.
Comment at: source/Plugins/Platform/CMakeLists.txt:8
+#elseif (CMAKE_SYSTEM_NAME MATCHES "OpenBSD")
+ add_subdirectory(OpenBSD)
#elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin")
I would sort by subdirectory.
Repository:
rL LLVM
krytarowski added inline comments.
Comment at: include/lldb/Host/Config.h:35
+
+#include "lldb/Host/openbsd/Config.h"
krytarowski wrote:
> Missing in patch?
I think that Config.h should go away. It's almost empty. But it's beyond the
scope of this patch.
Whil
krytarowski added inline comments.
Comment at: include/lldb/Host/Config.h:35
+
+#include "lldb/Host/openbsd/Config.h"
Missing in patch?
Repository:
rL LLVM
https://reviews.llvm.org/D31131
___
lldb-commits mail
krytarowski added inline comments.
Comment at: source/Host/openbsd/Host.cpp:223
+
+#if 0
+lldb::DataBufferSP Host::GetAuxvData(lldb_private::Process *process) {
Wasn't it already gone from there?
Repository:
rL LLVM
https://reviews.llvm.org/D31131
___
krytarowski added a comment.
Fantastic!
I got a substantial portion of Process Plugin to work on NetBSD, to coordinate
the work feel free to join IRC `#lldb` at OFTC -- e.g. do not waste time on
FreeBSD Process Plugin.
Demo:
http://www.netbsd.org/~kamil/lldb/hello2.txt
I'm working on on remai
kettenis created this revision.
Herald added a subscriber: mgorny.
Add basic OpenBSD support. This is enough to be able to analyze core dumps for
OpenBSD/amd64, but not much beyond that.
Note that part of the changes to
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp fix a bug that probably aff
21 matches
Mail list logo
