[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

krytarowski added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBConfig.cmake:435 find_package(Backtrace) +check_symbol_exists(ppoll poll.h HAVE_PPOLL) labath wrote: > This needs `set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)` to detect ppoll on >

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

krytarowski added a comment. Fix from pkgsrc-wip to resurrect LLDB Standalone build in SVN r. 300654. From 3371648af049cb4b40427ef87dcafb4745f10e8d Mon Sep 17 00:00:00 2001 From: Kamil Rytarowski Date: Wed, 19 Apr 2017 06:17:30 +0200 Subject: [PATCH] lldb-netbsd: Upgrade

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

labath added a comment. It looks like you had a fun day yesterday. :) Unfortunately, I have to add to your problems, as I've had to revert your commit due to a fairly big problem. The problem that it can happen that the create-a-bunch-of-listening-sockets loop can sometimes only create an

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

This revision was automatically updated to reflect the committed changes. Closed by commit rL300579: Update LLDB Host to support IPv6 over TCP (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D31823?vs=95453=95616#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

clayborg accepted this revision. clayborg added a comment. I'm good if Pavel is good. https://reviews.llvm.org/D31823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz updated this revision to Diff 95453. beanz added a comment. Removing code I accidentally left in that was from debugging, and moving some duplicated code that @labath spotted out of the ifdef. https://reviews.llvm.org/D31823 Files: cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz updated this revision to Diff 95448. beanz added a comment. Updating patches to reflect feedback from zturner. https://reviews.llvm.org/D31823 Files: cmake/modules/LLDBConfig.cmake include/lldb/Host/Config.h include/lldb/Host/Config.h.cmake include/lldb/Host/MainLoop.h

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thank you for taking the time to do this. It looks like ppoll was added to linux quite a long time ago, but we still get some patches supporting surprisingly old kernels. I hope it doesn't

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz updated this revision to Diff 95355. beanz added a comment. Herald added a subscriber: mgorny. Updating to use MainLoop class, and refactor MainLoop class to operate on Windows. I've added error cases to the MainLoop class for functionality that is not supported. Specifically non-socket

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz added a reviewer: clayborg. beanz added a comment. Adding Greg to the reviewers list. https://reviews.llvm.org/D31823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

labath added a comment. In https://reviews.llvm.org/D31823#724334, @beanz wrote: > @labath, I could adapt this into the `MainLoop` class, but I would actually > want to change how that class hierarchy is implemented. Regardless of the > event handling/polling model you use much of the code is

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

zturner added inline comments. Comment at: include/lldb/Host/common/TCPSocket.h:55 + + std::map m_listen_sockets; }; jasonmolenda wrote: > zturner wrote: > > Any particular reason you're using a `std::map` instead of a `DenseMap` or > >

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

jasonmolenda added a comment. Looks good. I'd recommend adding clayborg as a reviewer and giving him a couple days to comment on this if he has time. He wrote all of this code originally. Comment at: include/lldb/Host/common/TCPSocket.h:55 + + std::map

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz added a comment. @labath, I could adapt this into the `MainLoop` class, but I would actually want to change how that class hierarchy is implemented. Regardless of the event handling/polling model you use much of the code is identical between the classes. I'd rather get rid of

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

zturner added a comment. Networking isn't my area of domain expertise, so these are mostly just general comments. Comment at: include/lldb/Host/common/TCPSocket.h:55 + + std::map m_listen_sockets; }; Any particular reason you're using a

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

labath added a comment. When I created the `MainLoop` class, i was hoping it would become the central place for all select-like functionality. Currently it uses pselect, but i don't see a reason we couldn't switch it to ppoll (but we actually don't have to, as the current implementation should

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

beanz created this revision. Herald added a subscriber: emaste. This patch adds IPv6 support to LLDB/Host's TCP socket implementation. Supporting IPv6 involved a few significant changes to the implementation of the socket layers, and I have performed some significant code cleanup along the way.