[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

This revision was automatically updated to reflect the committed changes. Closed by commit rL304976: Fix backtrace of noreturn functions situated at the end of a module (authored by labath). Changed prior to commit: https://reviews.llvm.org/D32022?vs=101555=101900#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

labath added a comment. Thanks for the review. I'm not entirely proud of how I implemented this, but I hope it's not too ugly either. The reason I opted for this approach is that I needed to implement the "if the module is null then decrement the address and recompute" logic in two places.

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Pavel, my apologies for not following up on this, we had a big push to get ready for a beta release/conference this week, but it wasn't fair to leave you hanging with this change.

Re: [Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

On 6 June 2017 at 18:41, Jim Ingham wrote: > This is WWDC week. We’ll try to find time to take a look at this, but > silence may mean preoccupation more than anything else… > I was not trying to imply it means anything else than that. However, after two months of inactivity,

Re: [Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

This is WWDC week. We’ll try to find time to take a look at this, but silence may mean preoccupation more than anything else… Jim > On Jun 6, 2017, at 6:53 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I'd like to commit this this week.

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

labath added a comment. I'd like to commit this this week. If you have any objections to how I implemented this, let me know, so I can adjust the approach. https://reviews.llvm.org/D32022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

labath updated this revision to Diff 101555. labath added a comment. Herald added a subscriber: srhines. Add documentation. https://reviews.llvm.org/D32022 Files: include/lldb/Core/Address.h include/lldb/Core/Section.h include/lldb/Target/SectionLoadList.h

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

labath added a comment. Jason, any thoughts on my comments above? https://reviews.llvm.org/D32022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

labath added a comment. Thank you for looking at this. My response is below. In https://reviews.llvm.org/D32022#733223, @jasonmolenda wrote: > Hi Pavel, I'd document the new flag in include/lldb/Core/Address.h where we > have documentation for the other flags being used. > > It seems like

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

jasonmolenda added a comment. Hi Pavel, I'd document the new flag in include/lldb/Core/Address.h where we have documentation for the other flags being used. It seems like we're fixing this a little indirectly, and I'm not sure it's the best approach. I want to make sure I understand the

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

jasonmolenda added a comment. Sorry Pavel, I kept meaning to look at this patch this week but hadn't yet. I will later today. When I read over your description of the problem, it sounded like a good fix - haven't looked at the code yet. https://reviews.llvm.org/D32022

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

labath added a comment. Jim, Jason, could one of you take a look at this please? This part of the code is not really my specialty, so I'd appreciate your thoughts on this. https://reviews.llvm.org/D32022 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

labath created this revision. When a call instruction is the last instruction in a function, the backtrace PC will point past the end of the function. We already had special code to handle that, but we did not handle the case where the PC ends up outside of the bounds of the module containing the