mgorny updated this revision to Diff 189503.
mgorny added a comment.
I've attempted to rebase Kamil's patch against the current sources. Please note
that this is not the final version; I'll add a test case and PID reading later.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D32149/new/
krytarowski planned changes to this revision.
krytarowski added a comment.
Suspended, I need to resurrect tracing of 1 thread and fix kernel bugs for
multiple threads first.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-commits ma
labath added a comment.
Affirmative. Tests should go in together with the feature they are testing.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
krytarowski added a comment.
In https://reviews.llvm.org/D32149#763008, @labath wrote:
> What was your decision on the core files? I was under the impression you were
> gonna add the zip files as well. If so, then they should go in at the same
> time.
In the same commit? If so I will try to a
labath added a comment.
What was your decision on the core files? I was under the impression you were
gonna add the zip files as well. If so, then they should go in at the same time.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-c
krytarowski added a comment.
Can we go with this change?
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski updated this revision to Diff 100035.
krytarowski added a comment.
Rebase to HEAD.
Apply "Error" -> "Status" rename.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/Process/elf-core/ProcessElfCore.cpp
krytarowski updated this revision to Diff 97150.
krytarowski added a comment.
Remove another unrelated style improvement.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
Files:
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source
krytarowski updated this revision to Diff 97149.
krytarowski added a comment.
Strip non-functional style improvements in unrelated code-parts.
Apply changes to address comments from Joerg.
Repository:
rL LLVM
https://reviews.llvm.org/D32149
Files:
source/Plugins/ObjectFile/ELF/ObjectFileE
krytarowski added a comment.
In https://reviews.llvm.org/D32149#739727, @labath wrote:
> In https://reviews.llvm.org/D32149#738250, @krytarowski wrote:
>
> > ping?
>
>
> Sorry, I wasn't responding partially because I was waiting to see how the
> discussion on https://reviews.llvm.org/D32434 sett
labath added a comment.
In https://reviews.llvm.org/D32149#738250, @krytarowski wrote:
> ping?
Sorry, I wasn't responding partially because I was waiting to see how the
discussion on https://reviews.llvm.org/D32434 settles, as I think it may have
effect on the test strategy. I'll write more t
Thanks, I will give it a try!
On 27.04.2017 17:59, Zachary Turner wrote:
> In case it's not obvious, note the space in the command I said to run.
> `git-clang-format` has a dash, and when you run `git clang-format`
> (with a space), it will run the file with the dash.
>
> On Thu, Apr 27, 2017 at
In case it's not obvious, note the space in the command I said to run.
`git-clang-format` has a dash, and when you run `git clang-format` (with a
space), it will run the file with the dash.
On Thu, Apr 27, 2017 at 8:58 AM Zachary Turner wrote:
> There is a file in the repo called git-clang-form
There is a file in the repo called git-clang-format. Make sure that file
is on your PATH somewhere, then just run `git clang-format`. It will only
touch lines that are part of your diff, and leave surrounding lines alone.
When making a diff, we only want to clang-format the lines we touched, not
krytarowski added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:302
+ // default 32 or 64 bit arch (without any architecture revision) based on
+ // object file's class.
if (header.e_type == ET_CORE) {
joerg wrote:
> Unrelated
joerg added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:55
const char *const LLDB_NT_OWNER_NETBSD = "NetBSD";
+const char *const LLDB_NT_OWNER_NETBSDCORE = "NetBSD-CORE";
const char *const LLDB_NT_OWNER_OPENBSD = "OpenBSD";
Not
krytarowski added a comment.
ping?
Repository:
rL LLVM
https://reviews.llvm.org/D32149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski updated this revision to Diff 96272.
krytarowski edited the summary of this revision.
krytarowski added a comment.
Herald added a subscriber: srhines.
Fix handling executable and shared library triple detection.
Apply changes from review.
Update revision summary.
Repository:
rL L
Thanks! I'm working on this, I will test new code soon and submit to review.
On 20.04.2017 15:51, Zachary Turner wrote:
> Note that getAsInteger returns false on success, so be careful!
> On Thu, Apr 20, 2017 at 6:09 AM Pavel Labath via Phabricator
> mailto:revi...@reviews.llvm.org>> wrote:
>
>
Note that getAsInteger returns false on success, so be careful!
On Thu, Apr 20, 2017 at 6:09 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://reviews.llvm.org/D32149#731920, @krytarowski wrote:
>
> > In https://reviews.llvm.org/D32149#7318
labath added a comment.
In https://reviews.llvm.org/D32149#731920, @krytarowski wrote:
> In https://reviews.llvm.org/D32149#731887, @labath wrote:
>
> > A test would infinitely times more valuable then a demo script. What is the
> > tiniest core file you can produce on NetBSD? (on linux we've go
krytarowski added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
// Set the elf OS version to NetBSD. Also clear the
kettenis added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
// Set the elf OS version to NetBSD. Also clear the ven
krytarowski added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
// Set the elf OS version to NetBSD. Also clear the
kettenis added a comment.
In https://reviews.llvm.org/D32149#731887, @labath wrote:
> A test would infinitely times more valuable then a demo script. What is the
> tiniest core file you can produce on NetBSD? (on linux we've gotten them down
> to about 20K) Then we could check that in and write
kettenis added a comment.
Generally looks reasonable to me. A few comments inline.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
//
krytarowski added a comment.
In https://reviews.llvm.org/D32149#731887, @labath wrote:
> A test would infinitely times more valuable then a demo script. What is the
> tiniest core file you can produce on NetBSD? (on linux we've gotten them down
> to about 20K) Then we could check that in and wr
labath added a comment.
A test would infinitely times more valuable then a demo script. What is the
tiniest core file you can produce on NetBSD? (on linux we've gotten them down
to about 20K) Then we could check that in and write a test for it...
Repository:
rL LLVM
https://reviews.llvm.org
krytarowski added a comment.
Demo:
http://netbsd.org/~kamil/lldb/firefox-core.typescript
Replay:
script -p ./firefox-core.typescript
BSD `script`(1) is incompatible with the GNU one, so I prepared a quick port to
Linux:
http://netbsd.org/~kamil/lldb/nbscript.c
`gcc nbscript.c -lutil -o nb
krytarowski created this revision.
krytarowski added a project: LLDB.
Correct detection of the NetBSD specific core(5) files.
The original code was apparently copied from FreeBSD
and it was buggy, because these BSDs are different and
do not share the same ELF layout for core(5) files.
Split Proce
30 matches
Mail list logo
