spyffe closed this revision.
spyffe added a comment.
Committed r303110.
https://reviews.llvm.org/D33077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
spyffe updated this revision to Diff 99052.
spyffe marked an inline comment as done.
spyffe added a comment.
Updated the Makefile to fix a problem caught by Pavel Labath.
Also relocated the new test to lang/objc.
https://reviews.llvm.org/D33077
Files:
clayborg added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/ptr_refs-objc/Makefile:10
+
+include $(LEVEL)/Makefile.rules
labath wrote:
> This looks like a copy-paste error, as you have everything twice.
good catch
Repository:
labath added a comment.
As this is an objective C feature, wouldn't a better place for it be in
testcases/lang/objc ?
Comment at:
packages/Python/lldbsuite/test/functionalities/ptr_refs-objc/Makefile:10
+
+include $(LEVEL)/Makefile.rules
This looks like a
spyffe created this revision.
`ptr_refs` exposed a problem in ClangASTContext's implementation; it uses an
accessor to convert a `QualType` into an `ObjCObjectPointerType`, but the
accessor is not fully general. `getAs()` is the safer way to go.
I've added a test case that uses `ptr_refs` in
