clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very close and overall very nice, just a few implementation details to take
care of.
Comment at: include/lldb/API/SBStructuredData.h:20-28
+ enum Type {
+
abhishek.aggarwal updated this revision to Diff 100108.
abhishek.aggarwal marked 9 inline comments as done.
abhishek.aggarwal added a comment.
Updating https://reviews.llvm.org/D33434: Added new API to SBStructuredData
class
- Made changes according to feedback
https://reviews.llvm.org/D33434
abhishek.aggarwal added a comment.
My comments are inlined. Please let me know if something still needs to be
changed.
Comment at: include/lldb/API/SBStructuredData.h:60
+ //--
+ size_t GetSize() const;
+
--
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
No need for the "StructuredDataType::" or "lldb::StructuredDataType::"
prefixes. Since we aren't using an enum class (it was before) and since all
enumerators start with "eStruct
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py:43
+# Now launch the process, and do not stop at entry point.
+process = target.LaunchSimple(
+None, None, self.get_process_w
abhishek.aggarwal marked 2 inline comments as done.
abhishek.aggarwal added a comment.
Thanks for your suggestions. I have made changes according to feedback and
submitting it here.
https://reviews.llvm.org/D33434
___
lldb-commits mailing list
lldb
abhishek.aggarwal updated this revision to Diff 100376.
abhishek.aggarwal added a comment.
Updating https://reviews.llvm.org/D33434: Added new API to SBStructuredData
class
- Removed inferior from test case (not required)
- fixed enum scope
https://reviews.llvm.org/D33434
Files:
include/lld