This revision was automatically updated to reflect the committed changes.
Closed by commit rL305686: Delete ProcessLauncherPosix (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D34236?vs=102667&id=103022#toc
Repository:
rL LLVM
https://reviews.llvm.org/D34236
Files:
labath added a comment.
In https://reviews.llvm.org/D34236#783186, @emaste wrote:
> LGTM from the FreeBSD side. The launch code for FreeBSD came from the
> original (in-process) implementation that Linux and FreeBSD shared.
Thanks Ed.
If anyone's interested in archaeology, that launch code wa
emaste accepted this revision.
emaste added a comment.
LGTM from the FreeBSD side. The launch code for FreeBSD came from the original
(in-process) implementation that Linux and FreeBSD shared.
https://reviews.llvm.org/D34236
___
lldb-commits mailin
emaste added a comment.
FreeBSD build and test in progress.
https://reviews.llvm.org/D34236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Unfortunately, posix_spawn does not satisfy all our needs for launching
processes on non-darwin platforms (according to its design rationale, that was
never the intention). The most notable one is the "launch a process for
debugging". Darwin seems to have added extension
jingham added a comment.
This patch doesn't remove support for posix_spawn on OS X - it is moving to the
macOS Host.mm. Kind of sad as posix_spawn was supposed to remove a lot of the
platform-dependent and error-prone parts of process launching from the system.
But you have to live with what
rnk added a comment.
`posix_spawn` is considered the preferred, efficient, canonical way to launch
processes on Mac. Are you sure you want to remove support for it?
https://reviews.llvm.org/D34236
___
lldb-commits mailing list
lldb-commits@lists.ll
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
NetBSD part looks good. In next step we can rename ProcessLauncherPosixFork to
ProcessLauncherPosix.
https://reviews.llvm.org/D34236
_
labath created this revision.
Herald added subscribers: mgorny, srhines.
ProcessLauncherPosix was using posix_spawn for launching the process,
but this function is not available on all platforms we support, and even
where it was avaialable, it did not support the full range of options we
require f
