karnajitw created this revision.
Herald added a subscriber: emaste.
This is the freebsd equivalent of https://reviews.llvm.org/rL238549.
The fix serves 2 purpose
1. LLDB should handle inferior process signals SIGSEGV/SIGILL/SIGBUS/SIGFPE the
way it is suppose to be handled. Prior to this fix th
karnajitw added a comment.
Adding the associated bugzilla link for this issue
https://bugs.llvm.org/show_bug.cgi?id=23699
[Before Fix]
[/home/karnajitw/llvm_50_public/build.symbol] $ bin/lldb
~/lldb_test_execs/sigsegv
(lldb) target create "/home/karnajitw/lldb_test_execs/sigsegv"
Current executa
labath added a reviewer: emaste.
labath added a comment.
Adding ed as freebsd owner.
The patch seems reasonable, we changed the behavior on linux in a similar way
couple of releases back -- SEGV is not a "crash", because the application can
generally handle it via a signal handler.
Repository
karnajitw updated this revision to Diff 106423.
karnajitw added a comment.
Updated the patch. While referring to the linux implementation, looks like I
have added a reinterpret_cast on message.GetFaultAddress which is not required
in the freebsd scenario.
Repository:
rL LLVM
https://reviews
emaste added a comment.
Sorry I missed this when first uploaded, I will look at it shortly.
For future uploads can you kindly include full context, as described in
https://llvm.org/docs/Phabricator.html?
Repository:
rL LLVM
https://reviews.llvm.org/D35223
emaste added a comment.
The patch LGTM, I will test it soon.
Repository:
rL LLVM
https://reviews.llvm.org/D35223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
emaste added a comment.
With this patch I observed three new failures on FreeBSD and three new
unexpected passes on FreeBSD. An example of a new failure:
==
FAIL: test_inferior_crashing_expr_step_and_expr_dwarf
(TestInferio
labath added a comment.
In https://reviews.llvm.org/D35223#834050, @emaste wrote:
> With this patch I observed three new failures on FreeBSD and three new
> unexpected passes on FreeBSD. An example of a new failure:
>
> ==
>
emaste added a comment.
> Actually, I think you probably need to extend the @skipIfLinux to apply to
> freebsd as well.
Oh, I mistook the source of the check_stop_reason assertion failure -- I
thought it was asserting before the step. In this case I agree the test should
be skipped on FreeBSD.
karnajitw updated this revision to Diff 110438.
karnajitw added a comment.
Herald added a subscriber: krytarowski.
Updated the diff to include the changes that were required in the test part.
Please verify.
Repository:
rL LLVM
https://reviews.llvm.org/D35223
Files:
packages/Python/lldbsu
emaste accepted this revision.
emaste added a comment.
This revision is now accepted and ready to land.
Still would appreciate diffs uploaded with full context - i.e.,
Note that you can upload patches created through various diff tools,
including git and svn. To make reviews easier, please alw
karnajitw added a comment.
Thanks for the info. I will make sure of it in future.
Repository:
rL LLVM
https://reviews.llvm.org/D35223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310591: Report inferior signals as signals, not exceptions,
on FreeBSD (authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D35223?vs=110438&id=110572#toc
Repository:
rL LLVM
http
> On Aug 8, 2017, at 12:02 AM, Pavel Labath via Phabricator via lldb-commits
> wrote:
>
> labath added a comment.
>
> In https://reviews.llvm.org/D35223#834050, @emaste wrote:
>
>> With this patch I observed three new failures on FreeBSD and three new
>> unexpected passes on FreeBSD. An exam
14 matches
Mail list logo