[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

aprantl created this revision. The DWO handling code can get confused by clang modules which also use skeleton CUs to point to the object file with the full debug info. This patch detects whether an object is a "real" DWO or a clang module and prevents LLDB from interpreting clang modules as DW

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

dblaikie added a comment. (Presumably this could use a test case?) Repository: rL LLVM https://reviews.llvm.org/D35740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

aprantl updated this revision to Diff 107734. aprantl added a comment. No with testcase of sorts. https://reviews.llvm.org/D35740 Files: packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp Index: source/Plugins

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I was under the impression that this was found by a test case failure. Anyway, given that we've got different kinds of DWARF CU's, wouldn't it be better to add an attribute describing them,

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

clayborg accepted this revision. clayborg added a comment. Looks like there already is a test case that was failing as Jim mentioned. Accepting based on that. https://reviews.llvm.org/D35740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL308850: Fix PR33875 by distinguishing between DWO and clang modules (authored by adrian). Changed prior to commit: https://reviews.llvm.org/D35740?vs=107734&id=107836#toc Repository: rL LLVM https:/

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

labath added a comment. I looked at this briefly last week but I could not find a good fix in the amount of time I had left. This fixes the current test failure, but it does not fix the underlying bug, which is that we (sometimes?) set the compile unit offset for non-dwo, non-dsym DIEs as 0. Th

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

On Fri, Jul 21, 2017 at 4:05 PM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg accepted this revision. > clayborg added a comment. > > Looks like there already is a test case that was failing as Jim mentioned. > Accepting based on that. > Ah, I was thinking more a test

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

Not at present, but you presumably know more about this than I do. Part of the point of Greg's extracting the DWARF parser from lldb and making it into it's own library in llvm was precisely so that somebody could then write a simple wrapper tool that would poke it with not necessarily complete

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham wrote: > Not at present, but you presumably know more about this than I do. Part > of the point of Greg's extracting the DWARF parser from lldb and making it > into it's own library in llvm was precisely so that somebody could then > write a simple wrap

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

> On Jul 22, 2017, at 2:26 PM, David Blaikie wrote: > > > > On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham > wrote: > Not at present, but you presumably know more about this than I do. Part of > the point of Greg's extracting the DWARF parser from lldb and making it in

Re: [Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

On Sun, Jul 23, 2017 at 10:54 AM Adrian Prantl wrote: > On Jul 22, 2017, at 2:26 PM, David Blaikie wrote: > > > > On Fri, Jul 21, 2017 at 6:14 PM Jim Ingham wrote: > >> Not at present, but you presumably know more about this than I do. Part >> of the point of Greg's extracting the DWARF parser