[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

clayborg added a comment. We need a test for this to ensure we don't regress. https://reviews.llvm.org/D36620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

jasonmolenda closed this revision. jasonmolenda added a comment. Sendingsource/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Transmitting file data .done Committing transaction... Committed revision 311207. https://reviews.llvm.org/D36620 __

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

cbook added a comment. Thanks Jason. I don't have commit access. Would you or someone else be able to commit this? https://reviews.llvm.org/D36620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

jasonmolenda added a comment. This looks good, the documentation for isprint() say that the value of the argument must be representable as an unsigned char, or EOF. https://reviews.llvm.org/D36620 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

cbook created this revision. Prevent negative chars from being sign-extended into isprint and isspace which take and int and crash if the int is negative. https://reviews.llvm.org/D36620 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-r