[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 closed this revision. petpav01 added a comment. Landed as r315444 . Closing manually because I forgot to include "Differential Revision: ..." in the commit message. https://reviews.llvm.org/D38394 ___ lld

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 added a comment. Thanks, will commit shortly. https://reviews.llvm.org/D38394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

clayborg accepted this revision. clayborg added a comment. Looks good https://reviews.llvm.org/D38394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 updated this revision to Diff 118375. petpav01 added a comment. Updated patch contains the following changes: - Remove comments for `DataExtractor::GetMaxU32()` and `GetMaxU64()` from `DataExtractor.cpp` and keep only the Doxygen ones in the header file. - Restore assertion for `byte_si

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

clayborg added a comment. Looks good. Would be nice to add support for byte sizes of 3, 5 and 7 to the unchecked version as noted in inline comments, or remove the function if no one is using this function. Just a few quick fixes and this will be good to go. Comment at: sourc

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 added inline comments. Comment at: source/Utility/DataExtractor.cpp:566 size_t byte_size) const { - switch (byte_size) { - case 1: -return GetU8(offset_ptr); -break; - case 2: -return GetU16(offset_ptr); -break; - ca

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

zturner added inline comments. Comment at: source/Utility/DataExtractor.cpp:566 size_t byte_size) const { - switch (byte_size) { - case 1: -return GetU8(offset_ptr); -break; - case 2: -return GetU16(offset_ptr); -break; - cas

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

jingham added a comment. See inlined comments. Comment at: source/Core/DumpDataExtractor.cpp:275-281 + // Reject invalid item_byte_size. + if (item_byte_size > 8) { +s->Printf("error: unsupported byte size (%" PRIu64 ") for char format", + (ui

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 added a comment. Thank you for the initial review. Comment at: source/Core/DumpDataExtractor.cpp:275-281 + // Reject invalid item_byte_size. + if (item_byte_size > 8) { +s->Printf("error: unsupported byte size (%" PRIu64 ") for char format", +

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

jingham added a comment. This looks fine to me. I'd give Greg a little time to weigh in, this is much more his code than mine. But I don't see any problem with this, and thanks for the tests! Comment at: source/Core/DumpDataExtractor.cpp:275-281 + // Reject invalid ite

[Lldb-commits] [PATCH] D38394: Fix dumping of characters with non-standard sizes

petpav01 created this revision. Herald added subscribers: kristof.beyls, aemerson. - Prevent dumping of characters in `DumpDataExtractor()` with `item_byte_size` bigger than 8 bytes. This case is not supported by the code and results in a crash because the code calls `DataExtractor::GetMaxU64Bit