This revision was automatically updated to reflect the committed changes.
Closed by commit rL317277: Remove getCategories mechanism of specifying test
categories (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D39515
Files:
lldb/trunk/packages/Python/lldbsuite/test/exampl
jingham accepted this revision.
jingham added a comment.
Very nice, thanks!
https://reviews.llvm.org/D39515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath updated this revision to Diff 121287.
labath added a comment.
Herald added a subscriber: ki.stfu.
This removes the getCategories function altogether. I've moved the
filesystem-based category computation (which was implemented as a getCategories
base case) into the consumer, so that it is i
labath added a comment.
I agree that we have too many ways of specifying categories. I think that the
file-based and getCategories() way are redundant, particularly, as we tend to
only have one test file per directory anyway. For very fine grained
annotations, we can use the `@add_test_categori
jingham added a comment.
Setting categories on directories seems much less useful if you then have to
scan through all the tests and see if any of the tests in the directories
you've added categories to implement getCategories then add the new category to
the return from getCategories list as w
clayborg added a comment.
No objections from me as I don't use these categories.
https://reviews.llvm.org/D39515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
Does anyone care about these tests being in the basic_process category?
The getCategories function is interfering with the filesystem-based
watchpoint category kicking in. If there's any interest in keeping it,
then I can certainly make it happen. However, I haven't s
