This revision was automatically updated to reflect the committed changes.
Closed by commit rL319162: elf-core: Convert remaining register context to use
register set maps (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D40133
Files:
lldb/trunk/source/Plugins/Process/elf-c
labath updated this revision to Diff 124064.
labath added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: mgorny.
This is a slight deviation from the initial approach. What I've done here is
that I've kept the register set indices in an os-specific form. I've
labath planned changes to this revision.
labath added a comment.
I am going to come back to this later, with a slightly different approach, but
first I need to do another cleanup elsewhere.
https://reviews.llvm.org/D40133
___
lldb-commits mailing l
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:58
+enum class CoreRegset : uint8_t { GPR, FPR, PPC_VMX, PPC_VSX };
+
labath wrote:
> clayborg wrote:
> > Seems weird to have PPC_VMX and PPC_VSX define in a CoreRegSet
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:58
+enum class CoreRegset : uint8_t { GPR, FPR, PPC_VMX, PPC_VSX };
+
clayborg wrote:
> Seems weird to have PPC_VMX and PPC_VSX define in a CoreRegSet? Do these need
> t
It would be great if we could eventually just use llvm-tblgen to generate
all these register definitions.
On Fri, Nov 17, 2017 at 9:54 AM Greg Clayton via Phabricator via
lldb-commits wrote:
> clayborg added inline comments.
>
>
>
> Comment at: source/Plugins/Process/elf-core/el
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/elf-core-enums.h:58
+enum class CoreRegset : uint8_t { GPR, FPR, PPC_VMX, PPC_VSX };
+
Seems weird to have PPC_VMX and PPC_VSX define in a CoreRegSet? Do these need
to be specific for
labath added a comment.
In https://reviews.llvm.org/D40133#927655, @krytarowski wrote:
> I'm just thinking whether change code like `CoreRegset::PPC_VMX` to
> `CoreRegset::PPC::VMX`. I'm planning to add `CoreRegset::X86_64::XSAVE` in
> future.
That's an interesting idea, but I don't see how w
alexandreyy added a comment.
Looks good to me!
https://reviews.llvm.org/D40133
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Looks reasonable!
I'm just thinking whether change code like `CoreRegset::PPC_VMX` to
`CoreRegset::PPC::VMX`. I'm planning to add `CoreRegset::X86_64::XSAVE` in
future.
https://reviews.llvm.org/D40133
___
lldb-commits
labath created this revision.
Herald added subscribers: kbarton, kristof.beyls, javed.absar, nemanjai,
emaste, aemerson.
In https://reviews.llvm.org/D39681, we started using a map instead passing a
long list of
register sets to the ppc64le register context. However, existing
register sets were s
11 matches
Mail list logo
