Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-20 Thread Robinson, Paul via lldb-commits
s.llvm.org; reviews+d40211+public+c1500ec8aeff1...@reviews.llvm.org; jdevliegh...@apple.com; jan.kratoch...@redhat.com Subject: Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods You can make structs that are host and byte-order independent, LLVM is filled

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-20 Thread Zachary Turner via lldb-commits
You can make structs that are host and byte-order independent, LLVM is filled with stuff like this. And while you might end up processing the information off in a way that it can be stored in a single compile unit without such a struct, it still can be useful when you're actually *doing* the parsi

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-20 Thread Greg Clayton via lldb-commits
sizeof(struct) tends to include system level padding for the current host. But to answer your question, no there isn't a structure defined like this and we wouldn't use them anyway as we want to fill out one compile unit struct that works for both. > On Nov 20, 2017, at 8:01 AM, Zachary Turner

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-20 Thread Zachary Turner via lldb-commits
Right but isn’t there a DWARF64_HEADER and DEARF32_HEADER struct somewhere? This way you could just say return m_isdwarf64 ? sizeof(DWARF64_HEADER) : sizeof(DWARF32_HEADER); On Mon, Nov 20, 2017 at 7:50 AM Greg Clayton wrote: > > On Nov 19, 2017, at 4:56 PM, Zachary Turner wrote: > > > > On Sun

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-20 Thread Greg Clayton via lldb-commits
> On Nov 19, 2017, at 4:56 PM, Zachary Turner wrote: > > > > On Sun, Nov 19, 2017 at 6:35 AM Jan Kratochvil via Phabricator via > lldb-commits > wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL318626:

Re: [Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-19 Thread Zachary Turner via lldb-commits
On Sun, Nov 19, 2017 at 6:35 AM Jan Kratochvil via Phabricator via lldb-commits wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL318626: Add comments to DWARFCompileUnit length > fields/methods (authored by jankratochvil). > > Changed prior t

[Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-19 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318626: Add comments to DWARFCompileUnit length fields/methods (authored by jankratochvil). Changed prior to commit: https://reviews.llvm.org/D40211?vs=123472&id=123498#toc Repository: rL LLVM https

[Lldb-commits] [PATCH] D40211: Add comments to DWARFCompileUnit length fields/methods

2017-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a subscriber: lldb-commits. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. If you are confident that the behavior you are documenting is correct, I think you can submit patches like these without approval. If you do end up send