This revision was automatically updated to reflect the committed changes.
Closed by commit rL320071: Disable warnings related to anonymous types in the
ObjC plugin (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D40757?vs=125816&id=125999#toc
Repository:
rL LLVM
htt
davide added a comment.
LGTM (again)
https://reviews.llvm.org/D40757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
Cool. Thanks.
https://reviews.llvm.org/D40757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vsk updated this revision to Diff 125816.
vsk retitled this revision from "Disable warnings related to anonymous types"
to "Disable warnings related to anonymous types in the ObjC plugin".
vsk edited the summary of this revision.
vsk added a comment.
- Thanks @labath! I've disabled the GNU warnin
labath accepted this revision.
labath added a comment.
In https://reviews.llvm.org/D40757#944293, @vsk wrote:
> I'd like to make this a narrower change as well, but unfortunately, I haven't
> found a way to add in extra CXX flags through the add_library or
> llvm_add_library utilities. Somebody
vsk added a comment.
In https://reviews.llvm.org/D40757#943483, @labath wrote:
> If the "excuse" for not following llvm here is that these structs mirror
> apple headers, should we restrict these warnings only to the relevant files
> (e.g. everything in `source/Plugins/Language/ObjC`)?
>
> I do
labath added a comment.
If the "excuse" for not following llvm here is that these structs mirror apple
headers, should we restrict these warnings only to the relevant files (e.g.
everything in `source/Plugins/Language/ObjC`)?
I don't particularly care about whether we do, but I wanted to throw
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM, I stumbled upon the same issue :)
An alternative would be that of naming (as you suggested), but if this is
consistent, no worries.
https://reviews.llvm.org/D40757
__
vsk created this revision.
Herald added a subscriber: mgorny.
Various part of lldb make use of anonymous structs and unions. In every case
I've seen the usage is idiomatic, and doesn't deserve a warning.
For example, logic in the NSDictionary and NSSet plugins use anonymous structs
in a manner
