labath created this revision.
labath added a reviewer: clayborg.
Herald added subscribers: JDevlieghere, emaste.
These two functions were calling each other, while handling different
branches of the if(IsInMemory()). I am assuming this had a reason at
some point in the past, but right now it's jus
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D41169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
clayborg accepted this revision.
clayborg added a comment.
This was left over from before we mmap'ed the entire object file into memory.
Removing it is fine as the backing DataBufferSP for the object file will be
mmaped or not depending on where the file was loaded from and if the section
isn't
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320705: ObjectFile: remove
ReadSectionData/MemoryMapSectionData mutual recursion (authored by labath,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41169?vs=126723&id=126949#toc
R
