[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

This revision was automatically updated to reflect the committed changes. Closed by commit rL323450: Use test-specific module caches to avoid stale header conflicts (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

vsk added a comment. Is this OK to commit? https://reviews.llvm.org/D42277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

aprantl added a comment. Okay got it. I'll investigate the PR separately. https://reviews.llvm.org/D42277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

vsk added a comment. In https://reviews.llvm.org/D42277#985002, @aprantl wrote: > > Skip tests which fail when -fmodules is passed > > (https://bugs.llvm.org/show_bug.cgi?id=36048). > > Wait.. this patch is not supposed to change the set of tests that get > -fmodules passed to them. It should

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

aprantl added a comment. > Skip tests which fail when -fmodules is passed > (https://bugs.llvm.org/show_bug.cgi?id=36048). Wait.. this patch is not supposed to change the set of tests that get -fmodules passed to them. It should only add -fmodules-cache-path to tests that do pass -fmodules.

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

vsk updated this revision to Diff 131000. vsk added a comment. - Skip tests which fail when -fmodules is passed (https://bugs.llvm.org/show_bug.cgi?id=36048). https://reviews.llvm.org/D42277 Files:

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

vsk updated this revision to Diff 130686. vsk added a comment. Per an offline comment by Adrian, include -gmodules in the mandatory set of module flags. https://reviews.llvm.org/D42277 Files: packages/Python/lldbsuite/test/lang/objc/modules-auto-import/Makefile

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

labath added a comment. I don't know much about clang modules, but the change seems reasonable to me. https://reviews.llvm.org/D42277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

vsk updated this revision to Diff 130566. vsk added a comment. - Upload a diff with context. https://reviews.llvm.org/D42277 Files: packages/Python/lldbsuite/test/lang/objc/modules-auto-import/Makefile packages/Python/lldbsuite/test/lang/objc/modules-incomplete/Makefile

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

aprantl added a comment. Thanks, this is a great start! Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:240 +CLANG_MODULE_CACHE_DIR := module-cache + Is it safe that this is a relative path? Comment at:

[Lldb-commits] [PATCH] D42277: Use test-specific module caches to avoid stale header conflicts

vsk created this revision. vsk added reviewers: aprantl, davide, jasonmolenda, labath. Herald added a subscriber: eraman. Stale global module caches cause problems for the bots. The modules become invalid when clang headers are updated by version control, and tests which use these modules fail to