This revision was automatically updated to reflect the committed changes.
Closed by commit rL323673: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for
LLDB plugins on Linux (authored by mgorny, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
clayborg accepted this revision.
clayborg added a comment.
Looks good.
https://reviews.llvm.org/D42317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mgorny added inline comments.
Comment at: source/Host/linux/HostInfoLinux.cpp:208
bool HostInfoLinux::ComputeSystemPluginsDirectory(FileSpec &file_spec) {
- FileSpec temp_file("/usr/lib/lldb/plugins", true);
+ FileSpec temp_file("/usr/lib" LLDB_LIBDIR_SUFFIX "/lldb/plugins", t
clayborg added a comment.
See inlined comment
https://reviews.llvm.org/D42317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added inline comments.
Comment at: source/Host/linux/HostInfoLinux.cpp:208
bool HostInfoLinux::ComputeSystemPluginsDirectory(FileSpec &file_spec) {
- FileSpec temp_file("/usr/lib/lldb/plugins", true);
+ FileSpec temp_file("/usr/lib" LLDB_LIBDIR_SUFFIX "/lldb/plugins",
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
We have one plugin in-tree (tools/intel-features), but I'm not sure if anyone
uses/installs it.
In any case, the change seems like the right thing to do.
https://reviews.llvm.org/D42317
_
mgorny added a comment.
Disclaimer: I have never seen a plugin for LLDB. I've just noticed the wrong
path in `strace` output and fixed it ;-).
https://reviews.llvm.org/D42317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
mgorny created this revision.
mgorny added reviewers: k8stone, zturner, beanz.
Fix the Linux plugin lookup path to include appropriate libdir suffix
for the system. To accomplish this, store the value of
LLVM_LIBDIR_SUFFIX in lldb/Host/Config.h as LLDB_LIBDIR_SUFFIX,
and use this variable when def
