stella.stamenova added a comment.
This broke the windows bot:
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1894
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
_
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB354466: [lldb] [ObjectFile/ELF] Fix recognizing NetBSD
images (authored by mgorny, committed by ).
Herald added a proje
labath added a comment.
Looks good to me. Thank you for writing the tests. @davide, do you have
anything to add here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
___
lldb-commits mailing list
ll
mgorny updated this revision to Diff 187358.
mgorny added a comment.
Switched to use shorter identifiers.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
Files:
lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core
lldb/lit/Modules/ELF/netbsd-core-a
mgorny updated this revision to Diff 187351.
mgorny added a comment.
Updated to include a non-stripped core.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
Files:
lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core
lldb/lit/Modules/ELF/netbsd-cor
mgorny updated this revision to Diff 187350.
mgorny added a comment.
Reduced the test .yaml to the absolute minimum.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
Files:
lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core
lldb/lit/Modules/ELF/ne
mgorny updated this revision to Diff 187264.
mgorny added a comment.
Herald added a subscriber: jdoerfert.
Added comments on how test data was generated.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
Files:
lldb/lit/Modules/ELF/Inputs/netbsd
krytarowski added inline comments.
Comment at: lldb/lit/Modules/ELF/netbsd-core.test:3
+
+# RUN: lldb-test object-file %S/Inputs/netbsd.core | FileCheck %s
+# CHECK: Architecture: x86_64-unknown-netbsd
krytarowski wrote:
> I propose to keep it as netbsd$VERSION-$
mgorny updated this revision to Diff 187261.
mgorny added a comment.
Rename tests as requested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D42870/new/
https://reviews.llvm.org/D42870
Files:
lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core
lldb/lit/Modules/ELF/netbsd-core-amd64.test
krytarowski added inline comments.
Comment at: lldb/lit/Modules/ELF/netbsd-core.test:3
+
+# RUN: lldb-test object-file %S/Inputs/netbsd.core | FileCheck %s
+# CHECK: Architecture: x86_64-unknown-netbsd
I propose to keep it as netbsd$VERSION-$ARCH.core
We will wa
krytarowski added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1359
+ // p = patchlevel
+ const uint32_t version_major = version_info / 1;
+ const uint32_t version_minor = (version_info % 1) / 100;
---
mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at: lldb/lit/Modules/ELF/netbsd-exec.yaml:1
+# Test whether NetBSD executables are recognized correctly.
+
I'm not sure if we should keep the whole file or try to strip this a bit.
C
mgorny updated this revision to Diff 187254.
mgorny marked an inline comment as done and an inline comment as not done.
mgorny retitled this revision from "Correct recognition of NetBSD images" to
"[lldb] [ObjectFile/ELF] Correct recognition of NetBSD images".
mgorny edited the summary of this rev
13 matches
Mail list logo
