This revision was automatically updated to reflect the committed changes.
Closed by commit rL326130: Partial fix for TestConflictingSymbol.py on Windows
(authored by amccarth, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43688?vs=13
labath added a subscriber: spyffe.
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D43688#1017831, @amccarth wrote:
> OK, as far as I can tell, Windows doesn't have anything equivalent to the
> .symtab: a DLL ha
amccarth added a comment.
In https://reviews.llvm.org/D43688#1017691, @labath wrote:
> In https://reviews.llvm.org/D43688#1017652, @amccarth wrote:
>
> > In https://reviews.llvm.org/D43688#1017638, @labath wrote:
> >
> > > On non-windows systems we're expected to pick up the name from the symbol
labath added a comment.
In https://reviews.llvm.org/D43688#1017652, @amccarth wrote:
> In https://reviews.llvm.org/D43688#1017638, @labath wrote:
>
> > On non-windows systems we're expected to pick up the name from the symbol
> > table. Is there such a thing on windows as well?
>
>
> Given that
amccarth added a comment.
In https://reviews.llvm.org/D43688#1017638, @labath wrote:
> This test deliberately compiles without `-g`, so the variable should not be
> in the debug info.
Ah, that makes more sense than what I was thinking: that it was trying to make
sure the unused symbol wasn't
labath added a comment.
This test deliberately compiles without `-g`, so the variable should not be in
the debug info. On non-windows systems we're expected to pick up the name from
the symbol table. Is there such a thing on windows as well? Maybe you need to
lookup the symbol as `_conflicting_
amccarth created this revision.
amccarth added a reviewer: labath.
Herald added subscribers: aprantl, sanjoy.
Without this fix, the test ERRORs because the link of the inferior fails. This
patch adds the LLDB_TEST_API macro where needed and uses the new -2 magic value
for num_expected_locations
