[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

2018-02-26 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth abandoned this revision. amccarth added a comment. Abandoning. This isn't really working on Windows. The breakpoint fails to set for reasons I don't understand yet. https://reviews.llvm.org/D43784 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

2018-02-26 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth added a comment. Nice catch. I'll take a closer look to see what exactly is happening on Windows. https://reviews.llvm.org/D43784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

2018-02-26 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Btw, today I found out that this test is passing just accidentally because the CHECK lines are matching the output printed by the inferior and not the results of the evaluated expressions (the situation may be different on windows, if you don't do stdin/out redirection t

[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

2018-02-26 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth created this revision. amccarth added a reviewer: zturner. Herald added a subscriber: sanjoy. This test was passing unexpectedly, which causes ninja to short-circuit out of running the dotest.py tests. The bug report (https://bugs.llvm.org/show_bug.cgi?id=21765) appears to be obsolete