[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

jingham added a comment. This is great. I think I'm supposed to complain that there isn't a positive test that this flag works. This is in the testsuite, but that will just give a negative signal - that we aren't getting random failures that are maybe due to leaving built test products

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rL327330: Introduce a setting to disable Spotlight while running the test suite (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks @aprantl! https://reviews.llvm.org/D44342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl updated this revision to Diff 138086. aprantl added a comment. More review feedback. https://reviews.llvm.org/D44342 Files: include/lldb/Core/ModuleList.h lit/lit-lldb-init lit/lit.cfg packages/Python/lldbsuite/test/lldbtest.py source/Core/ModuleList.cpp

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

clayborg added inline comments. Comment at: source/Core/ModuleList.cpp:70 PropertyDefinition g_properties[] = { +// This option only makes sense when the host is macOS. +{"enable-external-lookup", OptionValue::eTypeBoolean, true, true, nullptr, Remove

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl added a comment. Thanks for the suggestion, Greg! I renamed to option to use a more generic name and removed the `#if APPLE` guards. https://reviews.llvm.org/D44342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl updated this revision to Diff 138082. aprantl added a comment. Renamed option to something more general. https://reviews.llvm.org/D44342 Files: include/lldb/Core/ModuleList.h lit/lit-lldb-init lit/lit.cfg packages/Python/lldbsuite/test/lldbtest.py source/Core/ModuleList.cpp

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl added a comment. In https://reviews.llvm.org/D44342#1034514, @labath wrote: > Does that mean we can remove the `.noindex` thingy from the build folder > name? (In any case, the change seems fine to me). Yes, but we could still keep it for performance reasons. Perhaps only on Darwin.

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

clayborg added a comment. I would rather see this done in a more generic fashion. Any platform should be able to enable/disable external symbol lookups. Maybe make this setting: (lldb) settings set symbols.enable-external-lookups false On Darwin this would mean dSYM. Any other platform can

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

labath added a comment. Does that mean we can remove the `.noindex` thingy from the build folder name? (In any case, the change seems fine to me). https://reviews.llvm.org/D44342 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

aprantl created this revision. aprantl added reviewers: jingham, vsk, labath. This is a more principled approach to disabling Spotlight .dSYM lookups while running the testsuite, most importantly it also works for the LIT-based tests, which I overlooked in my initial fix (renaming the test