This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB359773: Inject only relevant local variables in the
expression evaluation context (authored by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46551?vs=196965&id=197729#
teemperor updated this revision to Diff 196965.
teemperor added a comment.
- Disable the variable filtering when during tab completion for now, as it
seems our Clang lookup doesn't pull in external types which breaks the
completion tests (and others too). This is only a temporary fix to unblock
teemperor commandeered this revision.
teemperor added a reviewer: friss.
teemperor added a comment.
Shafik asked me to take a look at this and see if I can fix the completion
tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D46551/new/
https://reviews.llvm.org/D46551
> On May 8, 2018, at 1:32 AM, Pavel Labath via Phabricator
> wrote:
>
> labath added a comment.
>
> One could probably concoct an example (using macros, token pasting and such)
> where this would get it wrong, but that's probably not worth supporting.
Yeah, I thought about this and I’m not
labath added a comment.
One could probably concoct an example (using macros, token pasting and such)
where this would get it wrong, but that's probably not worth supporting.
Comment at: source/Expression/ExpressionSourceCode.cpp:193
+var_name == ConstString(".block_des
jingham accepted this revision.
jingham added a comment.
I'm still a little sad we can't get this to happen correctly in clang's lookup,
but this is a clever way to get the benefit of this workaround without paying
all the cost, and is a fine temporary solution.
The implementation looks okay to
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I forgot to increment from before continuing in my example. No need to update
code if you don't feel it is clearer
https://reviews.llvm.org/D46551
_
clayborg added inline comments.
Comment at: source/Expression/ExpressionSourceCode.cpp:174-179
+if ((from != 0 && clang::isIdentifierBody(body[from-1])) ||
+(from + var.size() != body.size() &&
+ clang::isIdentifierBody(body[from+var.size()]))) {
+ ++from
friss created this revision.
friss added reviewers: jingham, clayborg.
In r259902, LLDB started injecting all the locals in every expression
evaluation. This fixed a bunch of issues, but also caused others, mostly
performance regressions on some codebases. The regressions were bad
enough that we a
