[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

labath added a comment. In https://reviews.llvm.org/D46889#1104882, @aemerson wrote: > In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > > > Thanks for jumping on this Amara — I just wanted to point out that we > > ususally don't revert lldb changes that only break the lldb-xcode

Re: [Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

> On May 18, 2018, at 11:25 AM, Amara Emerson via Phabricator > wrote: > > aemerson added a comment. > > In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > >> Thanks for jumping on this Amara — I just wanted to point out that we >> ususally don't revert

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aemerson added a comment. In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > Thanks for jumping on this Amara — I just wanted to point out that we > ususally don't revert lldb changes that only break the lldb-xcode bot if they > pass on the lldb-cmake bot at the same time. When this

Re: [Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens it usually means that the lldb Xcode project must be updated and it's too much to

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aprantl added subscribers: jingham, jasonmolenda, labath. aprantl added a comment. Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aemerson reopened this revision. aemerson added a comment. This revision is now accepted and ready to land. Hi Pavel, I reverted this in r332730 due to the bot breaking. Please have a look and commit again when ready. Thanks, Amara Repository: rL LLVM https://reviews.llvm.org/D46889

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aemerson added a comment. This caused a failure in green dragon: http://green.lab.llvm.org/green/job/lldb-xcode/6644 Can you please fix or revert this change, thanks. Repository: rL LLVM https://reviews.llvm.org/D46889 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rL332719: [DWARF] Extract indexing code into a separate class hierarchy (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1984 GetObjectFile()->GetModule()->GetMutex()); - Index(); -} Yikes, who was

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

labath updated this revision to Diff 147326. labath added a comment. - s/AppleIndex/AppleDWARFIndex - move things to separate files https://reviews.llvm.org/D46889 Files: source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.h

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:40 + +std::unique_ptr AppleIndex::Create( +Module , DWARFDataExtractor apple_names, clayborg wrote: > Move all AppleIndex stuff to a dedicated .cpp file? Do we want

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

clayborg added a comment. Looks fine. Just one question on keeping the DWARFIndex::Create() functions so they all have the same signature. Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:40 + +std::unique_ptr AppleIndex::Create( +Module , DWARFDataExtractor

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

JDevlieghere added a comment. Looks good to me, but I'll defer to Greg as I've never actually touched this code myself. https://reviews.llvm.org/D46889 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

labath created this revision. labath added reviewers: clayborg, JDevlieghere. Herald added subscribers: aprantl, mgorny. This places the `if(m_using_apple_tables)` branches inside the SymbolFileDWARF class behind an abstract DWARFIndex class. The class currently has two implementations: -