mclow.lists added inline comments.
Herald added a project: LLVM.
Comment at: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:77
+ const char *swift_clang_resource_dir = "usr/lib/swift/clang";
+ auto parent = std::next(rev_it);
+ if (parent != r_end && *parent ==
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333933: Remove dependency from Host to clang. (authored by
zturner, committed by ).
Herald added a subscriber: llvm-commit
aprantl added a comment.
Generally I'm fine with improving the layering. I just wanted to point out that
the Swift language plugin also wants know the clang resource directory (it
calls `HostInfo::GetLLDBPath(ePathTypeClangDir, clang_dir_spec)`) since Swift
embeds Clang. That said it makes no s
labath added a reviewer: aprantl.
labath added a comment.
+Adrian.
I remember looking at the path computation code a while ago (I think it was in
the context of python though) and concluding that something like this would be
needed. Overall the patch seems fine to me, but I want to make sure it
zturner created this revision.
zturner added reviewers: labath, davide.
Herald added a subscriber: mgorny.
The idea is to move the discovery of the clang resource directory into a more
appropriate place, such as the clang expression parser. By continuing with
this pattern we can isolate all cla
