[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

xiaobai added a comment. In https://reviews.llvm.org/D47612#1118615, @labath wrote: > I don't understand the interactions between lldb framework and clang headers, > but if there isn't a better person to review this, I'm happy to rubber-stamp > it. :) Thanks! I don't quite understand it eithe

[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

This revision was automatically updated to reflect the committed changes. Closed by commit rL333777: Add dependency on clang-headers when building LLDB.framework using CMake (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.

[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't understand the interactions between lldb framework and clang headers, but if there isn't a better person to review this, I'm happy to rubber-stamp it. :) https://reviews.llvm.org/D47

[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

xiaobai created this revision. xiaobai added reviewers: clayborg, labath, sas. Herald added a subscriber: mgorny. The LLDB.framework generated when building with CMake + Ninja/Make is completely missing the clang headers. Although the code to copy them exists, we don't even generate them unless we