On 28/02/2019 20:29, Davide Italiano wrote:
On Thu, Feb 28, 2019 at 11:21 AM Davide Italiano wrote:
On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano wrote:
If I add:
diff --git a/lldb/source/Host/common/MainLoop.cpp
b/lldb/source/Host/common/MainLoop.cpp
index a4803936196..4fee76865ee
On Thu, Feb 28, 2019 at 11:21 AM Davide Italiano wrote:
>
> On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano
> wrote:
> >
> > If I add:
> >
> > diff --git a/lldb/source/Host/common/MainLoop.cpp
> > b/lldb/source/Host/common/MainLoop.cpp
> > index a4803936196..4fee76865ee 100644
> > ---
On Thu, Feb 28, 2019 at 11:19 AM Davide Italiano wrote:
>
> If I add:
>
> diff --git a/lldb/source/Host/common/MainLoop.cpp
> b/lldb/source/Host/common/MainLoop.cpp
> index a4803936196..4fee76865ee 100644
> --- a/lldb/source/Host/common/MainLoop.cpp
> +++ b/lldb/source/Host/common/MainLoop.cpp
>
If I add:
diff --git a/lldb/source/Host/common/MainLoop.cpp
b/lldb/source/Host/common/MainLoop.cpp
index a4803936196..4fee76865ee 100644
--- a/lldb/source/Host/common/MainLoop.cpp
+++ b/lldb/source/Host/common/MainLoop.cpp
@@ -23,6 +23,8 @@
// (ppoll is present but not implemented properly). On
On Thu, Feb 28, 2019 at 10:31 AM Davide Italiano wrote:
>
> On Thu, Feb 28, 2019 at 8:25 AM Raphael Isemann via lldb-commits
> wrote:
> >
> > Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via
> > lldb-commits :
> > >
> > > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote:
> > >
On Thu, Feb 28, 2019 at 8:25 AM Raphael Isemann via lldb-commits
wrote:
>
> Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via
> lldb-commits :
> >
> > On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote:
> > > On 28/02/2019 02:37, Davide Italiano via Phabricator wrote:
> > >>
Am Do., 28. Feb. 2019 um 17:11 Uhr schrieb Pavel Labath via
lldb-commits :
>
> On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote:
> > On 28/02/2019 02:37, Davide Italiano via Phabricator wrote:
> >> davide added a comment.
> >> Herald added a subscriber: jdoerfert.
> >> Herald added a
On 28/02/2019 16:18, Pavel Labath via lldb-commits wrote:
On 28/02/2019 02:37, Davide Italiano via Phabricator wrote:
davide added a comment.
Herald added a subscriber: jdoerfert.
Herald added a project: LLVM.
Pavel, this broke unicode handling for lldb on MacOS. If you type
something in the
On 28/02/2019 02:37, Davide Italiano via Phabricator wrote:
davide added a comment.
Herald added a subscriber: jdoerfert.
Herald added a project: LLVM.
Pavel, this broke unicode handling for lldb on MacOS. If you type something in
the lldb cmdline, it won't print the right character but a
davide added a comment.
Herald added a subscriber: jdoerfert.
Herald added a project: LLVM.
Pavel, this broke unicode handling for lldb on MacOS. If you type something in
the lldb cmdline, it won't print the right character but a series of unicode
sequences.
The main concern is that this also
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334393: [cmake] Detect presence of wide-char libedit at
build time (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
labath added inline comments.
Comment at: include/lldb/Host/Editline.h:72-76
#ifdef EL_CLIENTDATA /* editline with wide support + wide char read function
*/
using EditLineGetCharType = wchar_t;
#else
using EditLineGetCharType = char;
#endif
christos
christos added inline comments.
Comment at: include/lldb/Host/Editline.h:72-76
#ifdef EL_CLIENTDATA /* editline with wide support + wide char read function
*/
using EditLineGetCharType = wchar_t;
#else
using EditLineGetCharType = char;
#endif
labath
labath added inline comments.
Comment at: include/lldb/Host/Editline.h:72-76
#ifdef EL_CLIENTDATA /* editline with wide support + wide char read function
*/
using EditLineGetCharType = wchar_t;
#else
using EditLineGetCharType = char;
#endif
christos
christos added inline comments.
Comment at: include/lldb/Host/Editline.h:72-76
#ifdef EL_CLIENTDATA /* editline with wide support + wide char read function
*/
using EditLineGetCharType = wchar_t;
#else
using EditLineGetCharType = char;
#endif
labath
krytarowski added a comment.
The original reason to switch NetBSD to wide characters was to unbreak the
input parser. It used to mix wide and short characters.
Typing unicode characters doesn't work well here too (before applying the
patch):
`(lldb) za\U+017C\U+0142\U+0107
jankratochvil accepted this revision.
jankratochvil added a comment.
This revision is now accepted and ready to land.
No regressions on Fedora 28 x86_64. It does set there now
`LLDB_EDITLINE_USE_WCHAR` although one still cannot enter unicode characters to
`(lldb)` line.
labath added inline comments.
Comment at: include/lldb/Host/Editline.h:72-76
#ifdef EL_CLIENTDATA /* editline with wide support + wide char read function
*/
using EditLineGetCharType = wchar_t;
#else
using EditLineGetCharType = char;
#endif
It's not
labath created this revision.
labath added reviewers: krytarowski, uweigand, jankratochvil, timshen, beanz.
Herald added a subscriber: mgorny.
Instead of hardcoding a list of platforms where libedit is known to have
wide char support we detect this in cmake. The main motivation for this
is
19 matches
Mail list logo
