apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg, labath.
Herald added a subscriber: ki.stfu.
https://reviews.llvm.org/D47992
Files:
tools/lldb-mi/MICmdCmdExec.cpp
tools/lldb-mi/MICmdCmdExec.h
Index: tools/lldb-mi/MICmdCmdExec.h
=
apolyakov added a comment.
This patch uses changes from https://reviews.llvm.org/D47991. Is allows to:
(gdb)
-file-exec-and-symbols "bash"
^done
(gdb)
=library-loaded,id="/bin/bash",target-name="/bin/bash",host-name="/bin/bash",symbols-loaded="0",loaded_addr="-",size="0"
-exec-next
clayborg added inline comments.
Comment at: tools/lldb-mi/MICmdCmdExec.cpp:373-377
+ if (error.Success())
+return MIstatus::success;
+
+ SetError(error.GetCString());
+ return MIstatus::failure;
Maybe these four lines should be put into a utility function?
apolyakov added a comment.
If you look at `bool CMICmdCmdExecContinue::Execute()`, you'll see that there
are cases in which we need a flexible way to finish MI command(specific action
in error case for example). We have a few options: not to add such an utility
function, add and use it in simpl
clayborg added a comment.
In https://reviews.llvm.org/D47992#1134120, @apolyakov wrote:
> If you look at `bool CMICmdCmdExecContinue::Execute()`, you'll see that there
> are cases in which we need a flexible way to finish MI command(specific
> action in error case for example). We have a few op
