teemperor created this revision.
teemperor added a reviewer: stella.stamenova.
The test fails because we don't rewrite the slash behind `foo` to the OS
specific
separator (as the completion API doesn't support this kind of rewriting).
However,
we assume that this part of the string is rewritten
teemperor added a comment.
@stella.stamenova I don't have access to a Windows machine. Would you mind
testing if this fixes the issue?
https://reviews.llvm.org/D48746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
teemperor updated this revision to Diff 153408.
teemperor added a comment.
- Fixed an syntax error. Should work now.
https://reviews.llvm.org/D48746
Files:
unittests/Interpreter/TestCompletion.cpp
Index: unittests/Interpreter/TestCompletion.cpp
==
stella.stamenova accepted this revision.
stella.stamenova added a comment.
The test passes with the fix. Thanks!
https://reviews.llvm.org/D48746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335934: Fix path completion test case added in rL335905 on
Windows (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D487
