This revision was automatically updated to reflect the committed changes.
Closed by commit rL338733: Add byte counting mechanism to LLDBs Stream
class. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
teemperor updated this revision to Diff 158777.
teemperor added a comment.
- Fixing some of the merge conflicts.
- Fixed doxygen comment.
Thanks for the reviews!
https://reviews.llvm.org/D50159
Files:
include/lldb/Core/StreamAsynchronousIO.h
include/lldb/Core/StreamBuffer.h
JDevlieghere added inline comments.
Comment at: include/lldb/Utility/Stream.h:542
int m_indent_level; ///< Indention level.
+ std::size_t m_bytes_written = 0; /// The bytes this stream has written so
far.
I believe you need the `<` for Doxygen to
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I think there's a small difference in semantics between this and the `tell`
function on llvm streams. This tells the number of bytes written, while the
other one an absolute position within
teemperor updated this revision to Diff 158642.
teemperor edited the summary of this revision.
teemperor added a comment.
- Added some more documentation.
https://reviews.llvm.org/D50159
Files:
include/lldb/Core/StreamAsynchronousIO.h
include/lldb/Core/StreamBuffer.h
