[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-21 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342757: build: add libedit to include paths (authored by tkrasnukha, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51999?vs=166507&id=166522

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-21 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D51999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-21 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 166507. tatyana-krasnukha added a comment. LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't propagate lldbHost's include directories to lldbCore and lldbInterpreter. For lldbHost itself, I had to use PUBLIC, because its

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-20 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd added a comment. It definitely shouldn't be `PUBLIC`, `PRIVATE` makes sense for this inclusion. Is there a library that pulls in the dependency (that is, do the other libraries need it due to `lldbHost`? If so, just adding it as `INTERFACE` on that library should be sufficient). Re

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-20 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha updated this revision to Diff 166258. tatyana-krasnukha added a comment. Unfortunately, doing this only on `lldbHost` is not enough, because CMake doesn't propagate include directories to dependent projects. I added these lines to every project that includes "Editline.h". Rep

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-18 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Can you use `target_include_directories` instead and do this only on `lldbHost` instead please? That restricts the inclusion to just that target, which would help prevent accide

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-13 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added a comment. TBC, I pass libedit_INCLUDE_DIRS and libedit_LIBRARIES manually to CMake. Repository: rLLDB LLDB https://reviews.llvm.org/D51999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-12 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha added a comment. Everything that includes Host/Editline.h (Host/Editline.cpp, Core/IOHandler.cpp, ...). Build fails with "fatal error: histedit.h: No such file or directory" Repository: rLLDB LLDB https://reviews.llvm.org/D51999 _

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-12 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. How exactly are you building (i.e. what triggers this error)? Repository: rLLDB LLDB https://reviews.llvm.org/D51999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

2018-09-12 Thread Tatyana Krasnukha via Phabricator via lldb-commits
tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: compnerd. Herald added subscribers: lldb-commits, mgorny. Without that build of Host, Core and Interpreter with custom libedit fails. Repository: rLLDB LLDB https://reviews.llvm.org/D51999 Files: CMakeLists.txt