malaperle added a comment.
Gentle ping?
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
MaskRay added inline comments.
Comment at: tools/lldb-mi/MICmdCmdGdbSet.cpp:447
+bool CMICmdCmdGdbSet::OptionFnBreakpoint(
+ const CMIUtilString::VecString_t
&vrWords) {
+bool bPending = false;
clang-format
Reposito
MaskRay added a comment.
And there is no reviewers set :)
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
malaperle added a comment.
In https://reviews.llvm.org/D52953#1268810, @MaskRay wrote:
> And there is no reviewers set :)
I don't know who to add.
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@l
jingham added a reviewer: apolyakov.
jingham added a comment.
This looks okay to me, there's a trivial comment nit... But Alexander has been
doing the most work on MI recently, he might want to give this a look-over.
Repository:
rL LLVM
https://reviews.llvm.org/D52953
___
malaperle updated this revision to Diff 170301.
malaperle added a comment.
Clang-format it
https://reviews.llvm.org/D52953
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py
tools/lldb-mi/MICmdCmdBreak.cpp
tools/lldb-mi/MICmdCmdGdbSet.cpp
tools/lldb-mi/MICmdCm
apolyakov added a comment.
I think that it's worth it to rewrite the test with LIT and FileCheck because
the python approach has some limitations, e.g. timeouts. You can find examples
in `lldb/lit/tools/lldb-mi/`.
Comment at: tools/lldb-mi/MICmdCmdGdbShow.cpp:369
+const C
malaperle updated this revision to Diff 171388.
malaperle added a comment.
Convert to lit test, convert some code to an early return, clang-format.
https://reviews.llvm.org/D52953
Files:
lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
lit/tools/lldb-mi/breakpoint/inputs/break-
apolyakov added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4
+#
+# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g
+# RUN: %lldbmi < %s | FileCheck %s
As far as your first command is `file-exec-and-symbols`, t
malaperle updated this revision to Diff 171415.
malaperle added a comment.
Fixes to lit test
https://reviews.llvm.org/D52953
Files:
lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c
tools/lldb-mi/MICmdCmdBreak.cpp
to
malaperle marked an inline comment as done.
malaperle added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4
+#
+# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g
+# RUN: %lldbmi < %s | FileCheck %s
apolyakov wrot
apolyakov added a comment.
I ran the test and got a fail:
build/bin/llvm-lit -avv
llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
-- Testing: 1 tests, 1 threads --
FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of
1)
***
malaperle added a comment.
In https://reviews.llvm.org/D52953#1278331, @apolyakov wrote:
> I ran the test and got a fail:
Can you paste the full input of the failure? You can add
"--dump-input-on-failure" arg to FileCheck in the test. The test passes for me
but it might be that a regex needs
malaperle added inline comments.
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4
+#
+# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g
+# RUN: %lldbmi < %s | FileCheck %s
apolyakov wrote:
> malaperle wrote:
> > apolyakov wrote:
>
malaperle updated this revision to Diff 171436.
malaperle added a comment.
Remove need for second -file-exec-and-symbols
https://reviews.llvm.org/D52953
Files:
lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c
tools/ll
apolyakov added a comment.
I only have these options:
build/bin/llvm-lit -avv --dump-input-on-failure
llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
usage: llvm-lit [-h] [--version] [-j N] [--config-prefix NAME] [-D NAME=VAL]
[-q] [-s] [-v] [
apolyakov added a comment.
Here it is:
build/bin/llvm-lit -avv
llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
-- Testing: 1 tests, 1 threads --
FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of
1)
TEST 'lldb
malaperle updated this revision to Diff 171451.
malaperle added a comment.
Simply checks
I think those =breakpoint-modified checks are a bit overzealous. The important
check is whether of not we hit the breakpoint in a resolved location,
i.e. not 0x. So, at the *stopped. The presence and
malaperle added a comment.
In https://reviews.llvm.org/D52953#1278491, @malaperle wrote:
> Simply checks
*Simplify
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
apolyakov accepted this revision.
apolyakov added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
malaperle added a comment.
In https://reviews.llvm.org/D52953#1278523, @apolyakov wrote:
> LGTM.
Thanks a lot!
https://reviews.llvm.org/D52953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345563: [lldb-mi] Implement -gdb-set breakpoint pending
on/off (authored by malaperle, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52953?vs=171451&id=171629#toc
Repository:
rL
22 matches
Mail list logo
