JDevlieghere created this revision.
JDevlieghere added reviewers: labath, davide.
JDevlieghere added a project: LLDB.
Herald added subscribers: teemperor, emaste.
Replace calls to LLVM's is_directory with calls to LLDB's FileSytem class. For
this I introduced a new convenience method that, like t
krytarowski added a comment.
Why? We already put a lot of effort into reusing code from LLVM.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54135
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
JDevlieghere added a comment.
In https://reviews.llvm.org/D54135#1288254, @krytarowski wrote:
> Why? We already put a lot of effort into reusing code from LLVM.
This is still using code from LLVM, the `FileSystem` class is just an
abstraction in between:
1. It uses LLVM's virtual file system.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346375: [FileSystem] Add convenience method to check for
directories. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or