[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, This change looks fine to me but please wait for LLDB reviewer's decision. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54863/new/ https://r

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

labath accepted this revision. labath added a reviewer: clayborg. labath added a comment. The change looks pretty safe to me. Adding Greg in case he has any concerns. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54863/new/ https://reviews.llvm.org/D54863 __

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

davide added a comment. In D54863#1306947 , @martong wrote: > We have a change in Clang/ASTImporter which causes an LLDB assertion, unless > this patch is applied. > The related change is https://reviews.llvm.org/D53655 > > In that patch we change the im

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

clayborg accepted this revision. clayborg added a comment. Looks good to me as long as test suite is happy. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54863/new/ https://reviews.llvm.org/D54863 ___ lldb-commits

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

martong added a comment. > Can you write an lldb test for this? There is already an existing test for that: 2: test_expr_dwarf (TestSharedLib.SharedLibTestCase) Test that types work when defined in a shared library and forward-declared in the main executable ... python: ../../git/llvm/t

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

davide added a comment. In D54863#1308176 , @martong wrote: > > Can you write an lldb test for this? > > There is already an existing test for that: > > 2: test_expr_dwarf (TestSharedLib.SharedLibTestCase) > Test that types work when defined in a sh

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL347575: [ASTImporter] Set MustBuildLookupTable on PrimaryContext (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

martong added a comment. Thank you all for the review! :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54863/new/ https://reviews.llvm.org/D54863 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

[Lldb-commits] [PATCH] D54863: [ASTImporter] Set MustBuildLookupTable on PrimaryContext

martong added a comment. > Is this failing only on linux? Do you happen to have a buildbot link that > shows the failure? This LLDB patch is to prevent the buildbot failure when we commit this Clang/ASTImporter patch : https://reviews.llvm.org/D53655 Repository: rL LLVM CHANGES SINCE LAS