[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

2018-11-26 Thread Bruce Mitchener via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347637: Add support for the Dylan language to ClangASTContext (authored by brucem, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

2018-11-26 Thread Peter S. Housel via Phabricator via lldb-commits
housel updated this revision to Diff 175391. housel added a comment. Updated against r347619 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 Files: source/Symbol/ClangASTContext.cpp Index: source/Symbol/ClangASTContext.cpp

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

2018-11-26 Thread Bruce Mitchener via Phabricator via lldb-commits
brucem added a comment. I can land this today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

2018-11-26 Thread Peter S. Housel via Phabricator via lldb-commits
housel added a comment. I don't have commit access; could someone land this please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

2018-11-26 Thread Peter S. Housel via Phabricator via lldb-commits
housel updated this revision to Diff 175385. housel added a comment. Adds an inline comment about Open Dylan debug info CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54886/new/ https://reviews.llvm.org/D54886 Files: source/Symbol/ClangASTContext.cpp Index:

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

2018-11-26 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:123 + language == eLanguageTypeD || + language == eLanguageTypeDylan; } Please add a comment explaining that "The Debug info generated by the Open Dylan compiler's