[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, JDevlieghere, aprantl, davide, beanz. Herald added a subscriber: mgorny. Add features to LLDB CMake builds that have so far only been available in Xcode. Clean up a few inconveniences and prepare further improvements. Options:

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

clayborg added a comment. I like seeing all of the cmake modifications for the LLDB.framework. Are we planning on trying to get rid of the Xcode project at some point soon and use the auto generated one made by cmake? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://re

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added a comment. I am still running some remaining tests, but please let me know what you think about it in the meantime. In case you want to try this patch yourself, please checkout together with the related revisions (see Stack). ===

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

friss added a comment. In D55328#1320267 , @clayborg wrote: > I like seeing all of the cmake modifications for the LLDB.framework. Are we > planning on trying to get rid of the Xcode project at some point soon and use > the auto generated one made by cma

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 176954. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 176998. sgraenitz added a comment. Copy Clang headers to LLDB.framework without an intermediate staging directory. This approach seems much simpler and it avoids errors from an ordering issue at configuration time (preventing Clang headers from being copie

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177003. sgraenitz marked an inline comment as not done. sgraenitz added a comment. LLDB.framework requires an in-tree build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/m

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

labath added a comment. This looks fine to me. I don't know much about frameworks, but I think it makes things cleaner by grouping all the framework-related code together. It's not introduced in this patch, but the part that struck me as a hack has the force-overwriting of LLVM_CODESIGNING_IDEN

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz added a comment. Thanks for taking a look! > It's not introduced in this patch, but the part that struck me as a hack has > the force-overwriting of LLVM_CODESIGNING_IDENTITY. Is there any way that > could be removed? I agree, this is unfortunate. The problem is that we only have a s

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz added a comment. >> It's not introduced in this patch, but the part that struck me as a hack has >> the force-overwriting of LLVM_CODESIGNING_IDENTITY. Is there any way that >> could be removed? > > I agree, this is unfortunate. The problem is that we only have a single > global sett

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

labath added a comment. Printing the warning would definitely be nice. Making the identity overridable via llvm_codesign arguments also sounds reasonable if we want to have the flexibility of signing things with different identities. If we don't need that flexibility, can't we just have the us

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz added a comment. Working on it.. > .. if we want to have the flexibility of signing things with different > identities. Not sure if it's a good idea to sign with different identities within one build. Could become confusing? > If we don't need that flexibility, can't we just have th

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177229. sgraenitz added a comment. Improve handling of LLDB_CODESIGN_IDENTITY vs. LLVM_CODESIGNING_IDENTITY CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/modules/AddLLDB.c

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177231. sgraenitz added a comment. Finally fix that typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake cmake/modul

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + @labath Could this be a way to phase out LLDB_CODESIGN_IDEN

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + sgraenitz wrote: > @labath Could this be a way to phase out

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

labath added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + sgraenitz wrote: > sgraenitz wrote: > > @labath Could this be a way to phase out LLDB_CODESIGN_IDENTITY an

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177554. sgraenitz marked an inline comment as done and an inline comment as not done. sgraenitz added a comment. Move code sign changes to D55328 , minor improvements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl added inline comments. Comment at: resources/LLDB-Info.plist.in:18 + CFBundleSignature + + CFBundleVersion Just out of curiosity: Why this? Is this expected to be replaced after code signing? CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:64 + set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE) +endif() + labath wrote: > sgraenitz wrote: > > sgraenitz wrote: > > >

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: resources/LLDB-Info.plist.in:18 + CFBundleSignature + + CFBundleVersion aprantl wrote: > Just out of curiosity: Why this? Is this expected to be replac

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl added inline comments. Herald added a subscriber: michaelplatings. Comment at: cmake/modules/LLDBConfig.cmake:275 -if (CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR) - message(FATAL_ERROR "In-source builds are not allowed. CMake would overwrite " -"the makefiles distribute

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Let's give this a try. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 ___ lldb-commits maili

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl added a comment. Please be sure to watch all LLDB bots (green dragon and lab.llvm.org:8011) closely when landing this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 ___ lldb-commits

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

JDevlieghere accepted this revision. JDevlieghere added a comment. Sorry for the late review, I had a look originally but didn't have any comments. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added a comment. Thanks everyone for your patience with the review. I will spare us the potential merge conflicts before Christmas and land this after the holidays. Cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ ht

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL350391: [CMake] Revised LLDB.framework builds (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55328?vs=177554&id