labath created this revision.
labath added reviewers: clayborg, jasonmolenda, amccarth, lemo,
stella.stamenova.
This function was named such because in the case of MachO files, the
mach header is located at this address. However all (most?) usages of
this function were not interested in that fact
labath marked an inline comment as done.
labath added a comment.
Adding a bunch of people to make sure this makes sense for all object formats
(I am particularly oblivious to how COFF works). If this makes sense, I'll
implement this function in ObjectFilePECOFF and ELF to return the "image base"
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Just one clarification in the header documentation and this is good
to go.
Comment at: include/lldb/Symbol/ObjectFile.h:561
+ /// will have this section set
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1677
// Check to see if the module was read from memory?
- if (module_sp->GetObjectFile()->GetHeaderAddress().IsValid()) {
+ if
This revision was automatically updated to reflect the committed changes.
Closed by commit rL348849: Rename ObjectFile::GetHeaderAddress to
GetBaseAddress (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55422?vs=17
