[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

2019-01-03 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added a comment. > I recently started writing these early-exit returns as return {}; Good suggestion! > A testcase that triggers this situation would be nice, too. I think this is too tricky. If I understand correctly, an example of an unsafe-to-call thread state is when we're parke

[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

2019-01-03 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350375: [lldb] Check SafeToCallFunctions before calling functions in… (authored by kuba.brecka, committed by ). Changed prior to commit: https://reviews.llvm.org/D56115?vs=179589&id=180173#toc Repos

[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

2019-01-03 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. A testcase that triggers this situation would be nice, too. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:558 + if (!threa

[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

2018-12-27 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek created this revision. kubamracek added a reviewer: jingham. kubamracek added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D56115 Files: source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp Index: source/Plugins/LanguageRuntime/