[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

This revision was automatically updated to reflect the committed changes. Closed by commit rL353916: ObjectFilePECOFF: Create a "container" section spanning the entire module image (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1370 -auto section = section_list->GetSectionAtIndex(section_idx); +auto section = section_list-

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

labath marked an inline comment as done. labath added a comment. In D56537#1393202 , @amccarth wrote: > My knowledge of PECOFF is even more limited, but it's my understanding that > the ImageBase is the _preferred_ address for the module. That doesn't >

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1370 -auto section = section_list->GetSectionAtIndex(section_idx); +auto section = section_list->FindSectionByID(section_id); if (!section) How fast is this

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

amccarth added a comment. My knowledge of PECOFF is even more limited, but it's my understanding that the ImageBase is the _preferred_ address for the module. That doesn't guarantee that's the actual address it would be loaded at. Not just because of ASLR but also because there may be conflic

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

labath added a comment. Could you please take a look at this? This is currently blocking me from making progress with breakpad symbol files. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56537/new/ https://reviews.llvm.org/D56537 ___

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

labath created this revision. labath added reviewers: zturner, amccarth, stella.stamenova, clayborg. Herald added subscribers: abidh, JDevlieghere. This is coming from the discussion in D55356 (the most interesting part happened on the mailing list, so it isn't r